This repository was archived by the owner on May 13, 2024. It is now read-only.
condensed code into a method, called method#27
Open
meldaravaniel wants to merge 1 commit intowebrtc:solutionfrom
Open
condensed code into a method, called method#27meldaravaniel wants to merge 1 commit intowebrtc:solutionfrom
meldaravaniel wants to merge 1 commit intowebrtc:solutionfrom
Conversation
demo mentions a function that does this, yet the solution has the code duplicated in both the createRoom and joinRoomById methods. I consolidated those into one method, then had each aforementioned method call the new one with the corresponding strings. Also made those strings constants, since they're being used in three separate places.
wayjake
approved these changes
Aug 26, 2022
wayjake
left a comment
wayjake
left a comment
There was a problem hiding this comment.
This is a helpful addition to the code.
| }; | ||
|
|
||
| const callerCandidatesString = 'callerCandidates'; | ||
| const calleeCandidatesString = 'calleeCandidates'; |
There was a problem hiding this comment.
It would be more clear to remove "String" from the end of the variable declaration and make CALLER_CANDIDATES all caps to indicate it's a constant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
demo instructions mentions a function that does this, yet the solution has the code duplicated in both the createRoom and joinRoomById methods. I consolidated those into one method, then had each aforementioned method call the new one with the corresponding strings. Also made those strings constants, since they're being used in three separate places.